fix: enable using unit macro in foreign crate under test #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnabell
force-pushed
the
fix-unit-tests-foreign-crates-unit-macro
branch
2 times, most recently
from
53dfc35 to
c090850
Compare
Contributor
|
Are the merge conflicts preventing this PR from being merged? I think the issue resolved by it is stopping several people from using uom 0.37. |
Johnabell
force-pushed
the
fix-unit-tests-foreign-crates-unit-macro
branch
from
c090850 to
795b630
Compare
Contributor
Author
|
@TheComamba I have rebased to address the conflicts |
Where possible use an implicit return. Otherwise use an explicit `return` with a `;` terminating the statement.
* Add `--all-targets` argument. Add separate `cargo test --doc` because `--all-targets` excludes doc tests. * Replace deprecated `--all` argument with `--workspace`.
iliekturtles
force-pushed
the
fix-unit-tests-foreign-crates-unit-macro
branch
from
795b630 to
701c35a
Compare
Owner
|
Thanks for the PR. I pushed some changes to your branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raise in #520.
It adds a new macro that only outputs the tokens when this crate is running under test. This can then be used in other macros outputs in place of
#[cfg(test)]to ensure that when foreign crates use the exported macros the do not get the parts intended for internal testing.The other option that could be considered is making a
"testing"feature if you would like these to be available for testing in foreign crates too.